Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ExprPercent #5949

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Adds ExprPercent #5949

merged 1 commit into from
Aug 29, 2023

Conversation

sovdeeth
Copy link
Member

Description

Adds %number%(\\%| percent) of %numbers%, as requested by #2692.
Arguably does not complete the issue, but I'm of the opinion that 500 + 1% does not make much sense and should not equal 505.


Target Minecraft Versions:
Requirements:
Related Issues: #2692

@sovdeeth sovdeeth added enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature Pull request adding a new feature. and removed enhancement Feature request, an issue about something that could be improved, or a PR improving something. labels Aug 28, 2023
Copy link
Member

@AyhamAl-Ali AyhamAl-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean.

@AyhamAl-Ali
Copy link
Member

BTW the original related issue not a real issue, the behaviour is intended therefore your new expression does what the submitter wanted originally

Copy link
Contributor

@ahmadmsaleem ahmadmsaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! well done sovde!

@AyhamAl-Ali AyhamAl-Ali merged commit 34a36cc into SkriptLang:master Aug 29, 2023
4 checks passed
Moderocky pushed a commit to Moderocky/Skript that referenced this pull request Sep 16, 2023
@sovdeeth sovdeeth deleted the percentof branch September 26, 2023 17:14
NotSoDelayed pushed a commit to NotSoDelayed/Skript that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants